Skip to content

Update database.rst #12824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Update database.rst #12824

merged 1 commit into from
Dec 20, 2019

Conversation

abdounikarim
Copy link
Contributor

Hello,

I just add return type hint like the parent class : https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestCase.php

Cheers 😉

Hello, 

I just add return type hint like the parent class : https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestCase.php

Cheers 😉
@javiereguiluz
Copy link
Member

In theory this is not needed when using PhpUnitBridge ... but this component is not mandatory when testing Symfony apps ... so let's make the code of examples as standard as possible for PhpUnit too. Thanks!

javiereguiluz added a commit that referenced this pull request Dec 20, 2019
This PR was merged into the 5.0 branch.

Discussion
----------

Update database.rst

Hello,

I just add return type hint like the parent class : https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestCase.php

Cheers 😉

Commits
-------

9d1e2e0 Update database.rst
@javiereguiluz javiereguiluz merged commit 9d1e2e0 into symfony:5.0 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants