Skip to content

Use HttpKernel Component #12801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Use HttpKernel Component #12801

merged 1 commit into from
Jan 2, 2020

Conversation

demyanovs
Copy link
Contributor

We need to import Symfony\Component\HttpKernel before using it.

@javiereguiluz
Copy link
Member

@demyanovs thanks for this contribution too! However, this is probably expected. The // ... shown before the code means that "you must copy all the previous "use ..." imports and other code needed to run this example".

So, we must include the use ... only the first time we use some classes. Can you please confirm that this is the first time that HttpKernel classes are used in this tutorial? Thanks!

@demyanovs
Copy link
Contributor Author

@javiereguiluz thanks for the reply.
I double-checked. This is the first time we use this class. Although in the next part of the tutorial, it is already included. Perhaps this is not essential, but it can be embarrassing for beginners.

We need to import Symfony\Component\HttpKernel before using it.
@javiereguiluz javiereguiluz changed the base branch from master to 3.4 January 2, 2020 14:43
@javiereguiluz
Copy link
Member

@demyanovs I'm sorry it took us so long to merge this. Thanks for your contribution and congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Jan 2, 2020
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #12801).

Discussion
----------

Use HttpKernel Component

We need to import Symfony\Component\HttpKernel before using it.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

2cf09a9 Use HttpKernel Component
@javiereguiluz javiereguiluz merged commit 2cf09a9 into symfony:3.4 Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants