Skip to content

Added note regarding workflow "entered" event being dispatched on creation #12740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

Added note regarding workflow "entered" event being dispatched on creation #12740

merged 1 commit into from
Dec 3, 2019

Conversation

florentdestremau
Copy link
Contributor

Fixes #12732

noniagriconomie
noniagriconomie reviewed Nov 30, 2019
View reviewed changes
@OskarStark OskarStark added this to the 4.3 milestone Dec 3, 2019
OskarStark
OskarStark reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please add a .. versionadded:: 4.3 directive

@florentdestremau
Copy link
Contributor Author

@OskarStark so should I make a separate block for the whole sentence ?

@florentdestremau
Copy link
Contributor Author

phew sorry with the rebase I got confused and didn't want to introduce unnecessary modifications.
Is this good now @OskarStark and @noniagriconomie ?

@OskarStark
Copy link
Contributor

OskarStark commented Dec 3, 2019 •
edited
Loading

It took time, but here we go, this is in now. Thank you very much Florent.

Is this good now @OskarStark and @noniagriconomie ?

You did very well 👍

Congratulations on your first contribution on the Symfony documentation 🎉

cc fyi @lyrixx

OskarStark added a commit that referenced this pull request Dec 3, 2019
@OskarStark
feature #12740 Added note regarding workflow "entered" event being di…
0551609 
…spatched on creation (florentdestremau)

This PR was merged into the 4.3 branch.

Discussion
----------

Added note regarding workflow "entered" event being dispatched on creation

Fixes #12732

Commits
-------

f03df93 Added note regarding workflow "entered" event being dispatched on creation
noniagriconomie
noniagriconomie approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OskarStark OskarStark merged commit f03df93 into symfony:4.3 Dec 3, 2019
@florentdestremau florentdestremau deleted the 4.3 branch December 3, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@noniagriconomie noniagriconomie noniagriconomie approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@florentdestremau @OskarStark @noniagriconomie @carsonbot