Skip to content

Security: add example code which Maker Bundle generated #12657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Security: add example code which Maker Bundle generated #12657

wants to merge 2 commits into from

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Nov 21, 2019

See #11265

@mhujer mhujer force-pushed the security-what-maker-did branch from 232f42b to 87b3fa8 Compare November 21, 2019 21:42
@mhujer mhujer force-pushed the security-what-maker-did branch from 87b3fa8 to ae06b6c Compare December 11, 2019 09:15
@mhujer
Copy link
Contributor Author

mhujer commented Dec 11, 2019 •
edited
Loading

The PR is still targeting 4.3, but I have added another commit that updates te generated code to be in sync with the generated code for Symfony 5.0.

First commit should be merged to both 4.3 and 5.0, the second only to 5.0

@wouterj wouterj mentioned this pull request Nov 22, 2020
Merged
wouterj added a commit that referenced this pull request Nov 22, 2020
@wouterj
minor #14593 [Security] add example code which Maker Bundle generated…
145157b 
… (mhujer)

This PR was merged into the 4.4 branch.

Discussion
----------

[Security] add example code which Maker Bundle generated

Continues the work in #12657

Commits
-------

62c7f2b Security: add example code which Maker Bundle generated
@wouterj
Copy link
Member

wouterj commented Nov 22, 2020

Hi @mhujer!

This PR hasn't had any feedback from us, I'm sorry! For now, I think it's best not to include all code that's generated. This takes up quite some space on the page, which I don't think makes up for its usefulness. We're working on an improved build process for our docs, in which we also want to have collapsible code examples. If that's implemented, I'm definitely +1 for all changes in this PR (as space is no longer an issue).

In order to not have this PR stalled for any longer, I've taken your commits and removed some additions from it. The config example generated by the maker bundle makes sense to me, it's relatively small and includes new information. I've created a new PR with only these changes and merged it: #14593

For now, I'm going to close this PR, but let's remember the other changes in this PR if we get collapsible code examples 😄 (I'll leave the issue referencing this PR open). Thanks a lot for your work!

@wouterj wouterj closed this Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhujer @wouterj @carsonbot