Skip to content

Add note about .env.local being ignored in test environment #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

clemherreman
Copy link
Contributor

This PR add a short note, warning developers that the .env.local is always ignored on test environments.

This surprised me, because I am using PHP VCR to isolate my test suite. I set my real API credential in a .env.local, however I was suprised to see they were not used when running my test suite against the real API.

I am not sure about which branch I should target, so I aimed at the one when you click on "Edit this page" on the documentation page.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Dec 9, 2019
javiereguiluz added a commit that referenced this pull request Dec 9, 2019
…ent (clemherreman)

This PR was merged into the 4.3 branch.

Discussion
----------

Add note about .env.local being ignored in test environment

This PR add a short note, warning developers that the `.env.local` is always ignored on test environments.

This surprised me, because I am using PHP VCR to isolate my test suite. I set my real API credential in a `.env.local`, however I was suprised to see they were not used when running my test suite against the real API.

I am not sure about which branch I should target, so I aimed at the one when you click on "Edit this page" on the documentation page.

Commits
-------

3a5c137 Add note about .env.local being ignored in test environment
@javiereguiluz javiereguiluz merged commit 3a5c137 into symfony:4.3 Dec 9, 2019
@javiereguiluz
Copy link
Member

Thanks @clemherreman for improving the docs. We did some tweaks while merging to remove the .. note directive and merge this into the explanation of the .env.local file, so readers can't miss it. Thanks!

PS: you targeted the right branch! Thanks for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants