Fixed the explanation of the utf8 router option #12636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Nov 15, 2019
xabbuh
reviewed
Nov 18, 2019
| When this option is set to ``true``, route patterns can include UTF-8 characters. | ||
| When this option is set to ``true``, the regular expressions used in the | ||
| :ref:`requirements of route parameters <routing-requirements>` will match any | ||
| UTF-8 character when using ``.``, instead of matching only a single byte. |
There was a problem hiding this comment.
The u modifier influences a bit more than just the ., doesn't it? IIRC it also changes how the \w class matches for example.
wouterj
added a commit
that referenced
this pull request
Nov 23, 2019
…guiluz) This PR was merged into the 4.3 branch. Discussion ---------- Fixed the explanation of the utf8 router option Commits ------- 6884e4d Fixed the explanation of the utf8 router option
wouterj
added a commit
that referenced
this pull request
Nov 23, 2019
wouterj
added a commit
that referenced
this pull request
Nov 23, 2019
* 4.3: [#12636] Link to PHP.net's UTF-8 docs Fixed the explanation of the utf8 router option
wouterj
added a commit
that referenced
this pull request
Nov 23, 2019
* 4.4: [#12636] Link to PHP.net's UTF-8 docs Fixed the explanation of the utf8 router option
|
Thank Javier! I've updated this slightly in 4bf63bb, to make the explanation a bit broader + link to PHP.net's documentation the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.