Skip to content

fix some issues #12631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix some issues #12631

merged 1 commit into from
Nov 14, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark requested a review from wouterj November 13, 2019 08:35
@OskarStark OskarStark changed the base branch from master to 3.4 November 13, 2019 08:36
wouterj
wouterj approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

javiereguiluz
javiereguiluz approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you Oskar.

@OskarStark OskarStark added this to the 3.4 milestone Nov 14, 2019
OskarStark added a commit that referenced this pull request Nov 14, 2019
@OskarStark
minor #12631 fix some issues (OskarStark)
3f3138f 
This PR was merged into the 3.4 branch.

Discussion
----------

fix some issues

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

4b43d7c fix some issues
@OskarStark OskarStark merged commit 4b43d7c into symfony:3.4 Nov 14, 2019
@OskarStark OskarStark deleted the typos2 branch November 14, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @javiereguiluz @wouterj @carsonbot