Replace images by more recent one #12628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! Can you please update the exception image including the toolbar like before and try to decrease the size? ist ~260 kb vs. 76 kb before |
|
@OskarStark I will do it, but maybe should I wait until sf 4.4 lts is out, so will be more "stable" images? |
|
No let’s use them for 4.3 now and maybe update them later for 4.4 |
noniagriconomie
force-pushed
the
error_pages_images
branch
from
1b4c182 to
f27beb9
Compare
|
@OskarStark here you go note that i had to create a project with images are also compressed a little bit as requested cheers |
noniagriconomie
force-pushed
the
error_pages_images
branch
2 times, most recently
from
a1503bf to
285b832
Compare
wouterj
approved these changes
Nov 18, 2019
OskarStark
force-pushed
the
error_pages_images
branch
from
285b832 to
26763ac
Compare
OskarStark
added a commit
that referenced
this pull request
Nov 19, 2019
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12628). Discussion ---------- Replace images by more recent one Just more recent images (I was testing the 4.3 branch) I will do the same when 4.4 will be released Commits ------- 26763ac Replace images by more recent one
|
Thank you 👍 Would love to receive a PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just more recent images (I was testing the 4.3 branch)
I will do the same when 4.4 will be released