Add tip for trusted_proxies #12622
Merged
Add tip for trusted_proxies #12622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .. tip:: | ||
|
|
||
| In applications using :ref:`Symfony Flex <symfony-flex>` you can set the | ||
| TRUSTED_PROXIES env var: |
There was a problem hiding this comment.
Note to mergers ... do the following change while merging:
TRUSTED_PROXIES -> ``TRUSTED_PROXIES``
javiereguiluz
approved these changes
Nov 14, 2019
OskarStark
force-pushed
the
trusted-proxies
branch
from
014bd29 to
dd88a33
Compare
|
Good catch, thanks Fred. |
OskarStark
added a commit
that referenced
this pull request
Nov 14, 2019
* 4.3: minor. refs #12622 Add tip for trusted_proxies
OskarStark
added a commit
that referenced
this pull request
Nov 14, 2019
* 4.4: minor. refs #12622 Add tip for trusted_proxies
|
This doc change is tagged to 4.3 but automatic parsing of REMOTE_ADDR by setTrustedProxies is only available in 4.4, no? |
|
I am currently on a phone 📱, but if you are right 4.4 should (because of up merging) include this tip in the docs and 4.3 is not maintained anymore. Did you face any problems because of this in 4.3 ? |
|
What was weird was it seemed to work for us for a while on 4.3 but a recent
deploy broke it somehow, but as far as I know we were on 4.3 the whole
time. There's definitely no code to parse it in 4.3 though. Not a huge
deal, a fairly straightforward fix and we should be moving to 4.4/5 soon
anyway.
…On Thu, Feb 27, 2020 at 12:44 AM Oskar Stark ***@***.***> wrote:
I am currently on a phone 📱, but if you are right 4.4 should (because of
up merging) include this tip in the docs and 4.3 is not maintained anymore.
Did you face any problems because of this in 4.3 ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#12622?email_source=notifications&email_token=AJNMCSHBOUQO3QGQ5B227T3RE5OOHA5CNFSM4JMBEAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDE5OQ#issuecomment-591810234>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJNMCSDEM7GBOXVHMTHLVULRE5OOHANCNFSM4JMBEAHQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from #12384, a quick tip to help the flex user