-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update best_practices.rst #12617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update best_practices.rst #12617
Conversation
@amine-betari thanks! This is correct ... but the reword implies that you can access to ALL public services, and that's not true. So ... what if reword this again and say something like this:
|
@javiereguiluz done thank's. I thought we could access to all public services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to merge it
Thank you @amine-betari. |
This PR was squashed before being merged into the 4.3 branch (closes #12617). Discussion ---------- Update best_practices.rst // there is a public "router" service in the container $router = $this->container->get('router'); // this will not Work: MailLogger is a private service $mailLogger = $this->container->get(MailLogger::class); Commits ------- fcddead Update best_practices.rst
* 4.3: fix linelength. refs #12617
* 4.4: fix linelength. refs #12617 Update best_practices.rst
// there is a public "router" service in the container
$router = $this->container->get('router');
// this will not Work: MailLogger is a private service
$mailLogger = $this->container->get(MailLogger::class);