Skip to content

Tell user about installing twig #12616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Tell user about installing twig #12616

merged 1 commit into from
Nov 12, 2019

Conversation

Heaven31415
Copy link
Contributor

I tried to follow this subsection of tutorial and I noticed that I'm asked to create a file in a missing templates directory. I noticed that I'm missing this directory, because Twig isn't installed, so I simply installed it using composer which fixed the problem.

I changed the docs so people would know that they need to install Twig before moving on.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this change makes perfect sense. 👍 from me

Thanks for caring about further readers and taking the time to contribute to the docs!

@OskarStark OskarStark modified the milestones: 3.4, 4.3 Nov 12, 2019
@OskarStark OskarStark changed the base branch from master to 4.3 November 12, 2019 11:54
@OskarStark
Copy link
Contributor

Thank you @Heaven31415.

OskarStark added a commit that referenced this pull request Nov 12, 2019
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12616).

Discussion
----------

Tell user about installing twig

I tried to follow [this subsection of tutorial](https://symfony.com/doc/current/page_creation.html#rendering-a-template) and I noticed that I'm asked to create a file in a missing **templates** directory. I noticed that I'm missing this directory, because Twig isn't installed, so I simply installed it using composer which fixed the problem.

I changed the docs so people would know that they need to install Twig before moving on.

Commits
-------

5238703 Tell user about installing twig
@OskarStark OskarStark merged commit 5238703 into symfony:4.3 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants