[Security] Minor tweak in the impersonation explanation #12599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Nov 6, 2019
OskarStark
approved these changes
Nov 6, 2019
OskarStark
force-pushed
the
impersonation_roles
branch
from
56c7254 to
ed685a9
Compare
|
Thank you Javier. |
OskarStark
added a commit
that referenced
this pull request
Nov 6, 2019
…(javiereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #12599). Discussion ---------- [Security] Minor tweak in the impersonation explanation It's a minor change, but in the original text I don't know if it was clear that impersonated users keep their roles and Symfony adds a new one and doesn't replace the original roles. Commits ------- ed685a9 [Security] Minor tweak in the impersonation explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a minor change, but in the original text I don't know if it was clear that impersonated users keep their roles and Symfony adds a new one and doesn't replace the original roles.