-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update documentation for MercureBundle: add enable_profiler option #12598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just a few comments
This feature has been merged and released in MercureBundle 0.2. This PR can be merged in the 4.3 branch of the docs, because MercureBundle is a separate package already usable with Symfony 4.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I left 2 comments, but both can be fixed while merging this PR.
Thank you Vincent. |
…filer option (vincentchalamon) This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes #12598). Discussion ---------- Update documentation for MercureBundle: add enable_profiler option Related feature: symfony/mercure-bundle#13  Commits ------- 3705dae Update documentation for MercureBundle: add enable_profiler option
* 4.3: fixes versionadded directive. refs #12598 Update documentation for MercureBundle: add enable_profiler option Simply update the ESI initial specs date (dated 2001) Update doctrine.rst Tell user about installing twig fix some more typos
* 4.4: fixes versionadded directive. refs #12598 Update documentation for MercureBundle: add enable_profiler option Simply update the ESI initial specs date (dated 2001) Update doctrine.rst Tell user about installing twig fix some more typos
Page: https://symfony.com/doc/5.x/mercure.html#debugging Config instructions were added at symfony#12598 and later removed at symfony#15924 But I can't get the profiler to work. On which page am I supposed to open it? I guess on the one containing the JavaScript? (i.e. same page as I see the EventStrems in Chrome DevTools)? What do I have to do to get this to work? On the profiler page, the "Mercure" entry is always greyed out.
Page: https://symfony.com/doc/5.x/mercure.html#debugging Config instructions were added at symfony#12598 and later removed at symfony#15924 But I can't get the profiler to work. On which page am I supposed to open it? I guess on the one containing the JavaScript? (i.e. same page as I see the EventStrems in Chrome DevTools)? What do I have to do to get this to work? On the profiler page, the "Mercure" entry is always greyed out.
This PR was submitted for the 5.4 branch but it was merged into the 6.4 branch instead. Discussion ---------- [Mercure] Deleting forgotten(?) sentence Page: https://symfony.com/doc/5.x/mercure.html#debugging Config instructions were added at #12598 and later removed at #15924 But I can't get the profiler to work. On which page am I supposed to open it? I guess on the one containing the JavaScript? (i.e. same page as I see the EventStrems in Chrome DevTools)? What do I have to do to get this to work? On the profiler page, the "Mercure" entry is always greyed out. Commits ------- 5e60b34 Update mercure.rst: Deleting forgotten(?) sentence
Related feature: symfony/mercure-bundle#13