Skip to content

Update documentation for MercureBundle: add enable_profiler option #12598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Update documentation for MercureBundle: add enable_profiler option #12598

merged 1 commit into from
Nov 12, 2019

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Nov 6, 2019

Related feature: symfony/mercure-bundle#13

panel

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just a few comments

@dunglas
Copy link
Member

dunglas commented Nov 11, 2019

This feature has been merged and released in MercureBundle 0.2. This PR can be merged in the 4.3 branch of the docs, because MercureBundle is a separate package already usable with Symfony 4.3.

@wouterj wouterj removed the Waiting Code Merge Docs for features pending to be merged label Nov 11, 2019
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I left 2 comments, but both can be fixed while merging this PR.

@OskarStark OskarStark changed the base branch from master to 4.3 November 12, 2019 12:01
@OskarStark
Copy link
Contributor

Thank you Vincent.

OskarStark added a commit that referenced this pull request Nov 12, 2019
…filer option (vincentchalamon)

This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes #12598).

Discussion
----------

Update documentation for MercureBundle: add enable_profiler option

Related feature: symfony/mercure-bundle#13

![panel](https://user-images.githubusercontent.com/995707/68297999-9d299b00-0098-11ea-9662-86062da00bf8.png)

Commits
-------

3705dae Update documentation for MercureBundle: add enable_profiler option
OskarStark added a commit that referenced this pull request Nov 12, 2019
@OskarStark OskarStark merged commit 3705dae into symfony:4.3 Nov 12, 2019
OskarStark added a commit that referenced this pull request Nov 12, 2019
* 4.3:
  fixes versionadded directive. refs #12598
  Update documentation for MercureBundle: add enable_profiler option
  Simply update the ESI initial specs date (dated 2001)
  Update doctrine.rst
  Tell user about installing twig
  fix some more typos
OskarStark added a commit that referenced this pull request Nov 12, 2019
* 4.4:
  fixes versionadded directive. refs #12598
  Update documentation for MercureBundle: add enable_profiler option
  Simply update the ESI initial specs date (dated 2001)
  Update doctrine.rst
  Tell user about installing twig
  fix some more typos
ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Nov 7, 2024
Page: https://symfony.com/doc/5.x/mercure.html#debugging

Config instructions were added at symfony#12598 and later removed at symfony#15924

But I can't get the profiler to work. On which page am I supposed to open it? I guess on the one containing the JavaScript? (i.e. same page as I see the EventStrems in Chrome DevTools)?
What do I have to do to get this to work?
On the profiler page, the "Mercure" entry is always greyed out.
javiereguiluz pushed a commit to ThomasLandauer/symfony-docs that referenced this pull request Dec 5, 2024
Page: https://symfony.com/doc/5.x/mercure.html#debugging

Config instructions were added at symfony#12598 and later removed at symfony#15924

But I can't get the profiler to work. On which page am I supposed to open it? I guess on the one containing the JavaScript? (i.e. same page as I see the EventStrems in Chrome DevTools)?
What do I have to do to get this to work?
On the profiler page, the "Mercure" entry is always greyed out.
javiereguiluz added a commit that referenced this pull request Dec 5, 2024
This PR was submitted for the 5.4 branch but it was merged into the 6.4 branch instead.

Discussion
----------

[Mercure] Deleting forgotten(?) sentence

Page: https://symfony.com/doc/5.x/mercure.html#debugging

Config instructions were added at #12598 and later removed at #15924

But I can't get the profiler to work. On which page am I supposed to open it? I guess on the one containing the JavaScript? (i.e. same page as I see the EventStrems in Chrome DevTools)? What do I have to do to get this to work?
On the profiler page, the "Mercure" entry is always greyed out.

Commits
-------

5e60b34 Update mercure.rst: Deleting forgotten(?) sentence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants