Skip to content

Update form_themes.rst #12568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2019
Merged

Update form_themes.rst #12568

merged 1 commit into from
Nov 3, 2019

Conversation

patrickmaynard
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was verified by our native English friend Ciaran on Symfony's Slack. He also mentioned that we could do this other change too:

This makes Twig to look ... -> This makes Twig look ...

@OskarStark
Copy link
Contributor

OskarStark commented Nov 1, 2019 •
edited
Loading

@javiereguiluz is this also true for the new proposed version This causes Twig to look -> This causes Twig look, because after this change we don't use makes anymore 🤔

@OskarStark OskarStark added this to the 4.3 milestone Nov 1, 2019
@javiereguiluz
Copy link
Member

Oskar, the review was OK with the new proposal ... the other alternative that requires to remove the to word is only valid if we keep the original text. So, we've just merged this. Thanks Patrick and congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Nov 3, 2019
@javiereguiluz
minor #12568 Update form_themes.rst (patrickmaynard)
5515dd4 
This PR was merged into the 4.3 branch.

Discussion
----------

Update form_themes.rst

Commits
-------

480b349 Update form_themes.rst
@javiereguiluz javiereguiluz merged commit 480b349 into symfony:4.3 Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickmaynard @OskarStark @javiereguiluz @carsonbot