Skip to content

Update templates.rst #12548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Update templates.rst #12548

merged 1 commit into from
Oct 29, 2019

Conversation

joelindix
Copy link
Contributor

@joelindix joelindix commented Oct 26, 2019

In the last example of 'Template Inheritance and Layouts' the content block is defined inblog/layout.html.twig, not blog/index.html.twig

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing this.

javiereguiluz added a commit that referenced this pull request Oct 29, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

Update templates.rst

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

In the last example of  'Template Inheritance and Layouts' the content block is defined in`blog/layout.html.twig`, not `blog/index.html.twig`

Commits
-------

7ce0f32 Update templates.rst
@javiereguiluz javiereguiluz merged commit 7ce0f32 into symfony:4.3 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants