Skip to content

Change the default mapping type to XML #12542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Change the default mapping type to XML #12542

merged 1 commit into from
Nov 21, 2019

Conversation

sdudziak
Copy link
Contributor

YAML mapping are marked as deprecated for doctrine v2.6+ and will be removed in doctrine v3+ . https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/yaml-mapping.html#yaml-mapping

@sdudziak
Copy link
Contributor Author

sdudziak commented Nov 5, 2019

Hi @OskarStark
I've updated the code with your suggestions. What is the current state of this PR?

@xabbuh xabbuh added this to the 3.4 milestone Nov 21, 2019
@xabbuh xabbuh modified the milestones: 3.4, 4.3 Nov 21, 2019
@xabbuh
Copy link
Member

xabbuh commented Nov 21, 2019

Thank you @sdudziak.

xabbuh added a commit that referenced this pull request Nov 21, 2019
This PR was squashed before being merged into the 4.3 branch (closes #12542).

Discussion
----------

Change the default mapping type to XML

YAML mapping are  marked as deprecated for doctrine v2.6+ and will be removed in doctrine v3+ . https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/yaml-mapping.html#yaml-mapping

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

ca4a8a2 Change the default mapping type to XML
@xabbuh xabbuh merged commit ca4a8a2 into symfony:4.3 Nov 21, 2019
@sdudziak sdudziak deleted the patch-1 branch November 21, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants