Escape backslash before string termination #12504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Oct 18, 2019
javiereguiluz
approved these changes
Oct 18, 2019
To php, 'App\' looks like a string that contains a quote and is not finished. Using \\, the only escape sequence that works within single quotes, should fix the issue. This was introduced in 2a5b114 , which is only present on the master branch at the time.
javiereguiluz
force-pushed
the
escape-backslash-before-end-of-string
branch
from
870cde0 to
e92115e
Compare
|
Thanks Grégoire! Merged in 4.3 |
javiereguiluz
added a commit
that referenced
this pull request
Oct 18, 2019
This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12504). Discussion ---------- Escape backslash before string termination To php, `'App\'` looks like a string that contains a quote and is not finished. Using `\\`, the only escape sequence that works within single quotes, should fix the issue. This was introduced in 2a5b114 , which is only present on the master branch at the time, that's why I'm targetting master. Commits ------- e92115e Escape backslash before string termination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To php,
'App\'looks like a string that contains a quote and is not finished. Using\\, the only escape sequence that works within single quotes, should fix the issue.This was introduced in 2a5b114 , which is only present on the master branch at the time, that's why I'm targetting master.