Tweaked the middleware example in the Messenger component #12480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need some reviews here from people who know the Messenger component well. Thanks! |
javiereguiluz
added
the
help wanted
maxhelias
approved these changes
Oct 3, 2020
wouterj
force-pushed
the
middleware_tweak
branch
from
09644d5 to
d13d6a7
Compare
|
I checked the 4.2 docs, and they were explaining this more clearly. I've added some code comments and merged this PR. Thanks Javier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looked inconsistent to me: "default middleware" is disabled for XML and PHP but not YAML.