Skip to content

fixed scope example #12474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

fixed scope example #12474

merged 1 commit into from
Oct 15, 2019

Conversation

iarro
Copy link
Contributor

@iarro iarro commented Oct 14, 2019

Documentation contained some invalid informations about scope definition.

@javiereguiluz
Copy link
Member

@iarro good catch! However, I think the fix should use the SCOPE_ONE public const from QueryInterface, right? https://github.com/symfony/symfony/blob/6b3bbe4cc2d38329cccf47589fef653db3b0fd55/src/Symfony/Component/Ldap/Adapter/QueryInterface.php#L30

@javiereguiluz javiereguiluz added this to the 4.3 milestone Oct 15, 2019
@iarro
Copy link
Contributor Author

iarro commented Oct 15, 2019

Query implements QueryInterface, so there is no conflict. Both refers to same constant. But yes, you're right. It is more accurate use interface than concrete implementation.

@javiereguiluz
Copy link
Member

Thank you ... and congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Oct 15, 2019
@javiereguiluz
minor #12474 fixed scope example (iarro)
b823ec3 
This PR was squashed before being merged into the 4.3 branch (closes #12474).

Discussion
----------

fixed scope example

Documentation contained some invalid informations about scope definition.

Commits
-------

60b7dd7 fixed scope example
@javiereguiluz javiereguiluz merged commit 60b7dd7 into symfony:4.3 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ldap Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@iarro @javiereguiluz @carsonbot