Skip to content

[Doctrine] Promote DQL in favor of QueryBuilder #12469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

[Doctrine] Promote DQL in favor of QueryBuilder #12469

merged 1 commit into from
Oct 15, 2019

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 13, 2019

Fixes #10779

javiereguiluz
javiereguiluz approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! Thank you!

yceruto
yceruto reviewed Oct 14, 2019
View reviewed changes
@wouterj wouterj force-pushed the issue-10779/dql-in-favor-of-qb branch from 9d44bf6 to 93f4e8a Compare October 14, 2019 14:33
@wouterj
Copy link
Member Author

wouterj commented Oct 14, 2019

Thanks for the quick reviews. I've resolved all comments.

The Custom Transport section is a very weird one, as it "uses a dummy DB" with sort-of Doctrine syntax. I'll rewrite the example in a new PR (and make it just doctrine DBAL).

yceruto
yceruto approved these changes Oct 14, 2019
View reviewed changes
@wouterj wouterj force-pushed the issue-10779/dql-in-favor-of-qb branch from 93f4e8a to 03e07b0 Compare October 14, 2019 19:09
@javiereguiluz javiereguiluz added this to the 4.3 milestone Oct 15, 2019
javiereguiluz added a commit that referenced this pull request Oct 15, 2019
@javiereguiluz
minor #12469 [Doctrine] Promote DQL in favor of QueryBuilder (wouterj)
782b7a5 
This PR was merged into the 4.3 branch.

Discussion
----------

[Doctrine] Promote DQL in favor of QueryBuilder

Fixes #10779

Commits
-------

03e07b0 Promote DQL queries instead of QueryBuilder
@javiereguiluz javiereguiluz merged commit 03e07b0 into symfony:4.3 Oct 15, 2019
@javiereguiluz
Copy link
Member

Thank you Wouter. This is really nice!

@wouterj wouterj deleted the issue-10779/dql-in-favor-of-qb branch October 15, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Doctrine Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @javiereguiluz @yceruto @carsonbot