Skip to content

Highlighting possibilty to use FQCN as type value. #12419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Highlighting possibilty to use FQCN as type value. #12419

merged 1 commit into from
Oct 4, 2019

Conversation

ktherage
Copy link
Contributor

@ktherage ktherage commented Oct 4, 2019

No description provided.

@ktherage ktherage requested a review from xabbuh as a code owner October 4, 2019 11:12
@javiereguiluz javiereguiluz added this to the 3.4 milestone Oct 4, 2019
@javiereguiluz javiereguiluz changed the base branch from 4.3 to 3.4 October 4, 2019 15:46
javiereguiluz added a commit that referenced this pull request Oct 4, 2019
@javiereguiluz
minor #12419 Highlighting possibilty to use FQCN as type value. (kthe…
d97e75d 
…rage)

This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes #12419).

Discussion
----------

Highlighting possibilty to use FQCN as type value.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

24ad431 Highlighting possibilty to use FQCN as type value.
@javiereguiluz javiereguiluz merged commit 24ad431 into symfony:3.4 Oct 4, 2019
@javiereguiluz
Copy link
Member

Hi Kevin. Thanks for this contribution. The current docs already explained that you can use PHP classes ... but thanks to your contribution I realize that this wasn't clear enough.

So, instead of adding a tip about this, in a992448 I'v reworded this to improve the code listing and show a real example of this in practice (using @Assert\Type("Ramsey\Uuid\UuidInterface") for the id property of this imaginary entity).

@ktherage ktherage deleted the patch-1 branch October 7, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ktherage @javiereguiluz @carsonbot