[Translator] Recommending real message id for shared bundles #12236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
force-pushed
the
message_id_recommendation
branch
from
483b670 to
0def709
Compare
javiereguiluz
approved these changes
Sep 2, 2019
|
Thank you Yonel. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 6, 2019
…dles (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [Translator] Recommending real message id for shared bundles Using the "keyword" method to create translation message in public/shared bundles is painful sometimes, because apps with single-lenguage MUST activate the `translator` layer to see the final message, so worse performance. DX-wise, the "keyword" method is "practical" (nowaday smart IDEs can replace texts easier), but when we're creating a bundle we should also think that "translation" is optional for apps. Commits ------- 0def709 Recommending real message id for shared bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the "keyword" method to create translation message in public/shared bundles is painful sometimes, because apps with single-lenguage MUST activate the
translatorlayer to see the final message, so worse performance.DX-wise, the "keyword" method is "practical" (nowaday smart IDEs can replace texts easier), but when we're creating a bundle we should also think that "translation" is optional for apps.