[DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml() #12225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Aug 22, 2019
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
OskarStark
reviewed
Aug 28, 2019
OskarStark
reviewed
Aug 28, 2019
components/dom_crawler.rst
Outdated
| @@ -333,10 +349,18 @@ and :phpclass:`DOMNode` objects:: | |||
| // avoid the exception passing an argument that html() returns when node does not exist | |||
| $html = $crawler->html('Default <strong>HTML</strong> content'); | |||
|
|
|||
| $html = $crawler->outerHtml(); | |||
There was a problem hiding this comment.
lets move this below the versionadded of html() method, moving it away from the context makes not so much sense and Introduce the outherHtml()method with a short sentence after thehtml()` versionadded.
To be clear regarding the order:
html()code examplehtml()versionadded directiveoutherHtml()introduction/descriptionoutherHtml()code exampleoutherHtml()versionadded directive
Thanks.
There was a problem hiding this comment.
Ok got it 👍 thanks.
Is it better now ?
lyrixx
force-pushed
the
crawler-new-methods
branch
from
7749d72 to
35518f1
Compare
lyrixx
force-pushed
the
crawler-new-methods
branch
from
35518f1 to
a8599cf
Compare
OskarStark
approved these changes
Aug 28, 2019
carsonbot
added
Status: Reviewed
and removed
Status: Needs Review
Status: Needs Work
labels
|
Thanks for your work on this new feature! |
OskarStark
added a commit
to OskarStark/symfony-docs
that referenced
this pull request
Aug 28, 2019
xabbuh
added a commit
that referenced
this pull request
Aug 30, 2019
OskarStark
added a commit
that referenced
this pull request
Sep 2, 2019
* 4.4: Remove duplicated !!set tag [#12225] fix a small typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12223