Add a note for preload asset #12179
Merged
Add a note for preload asset #12179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 15, 2019
alamirault
force-pushed
the
fix-preload
branch
from
08b83a2 to
d9b88d7
Compare
OskarStark
approved these changes
Aug 16, 2019
|
Thank you Antoine. |
OskarStark
added a commit
that referenced
this pull request
Aug 16, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Add a note for preload asset This PR add a note about how to preload asset in Sf 3.4. Indeed it was not explained. There was just a symfony blog article about it : https://symfony.com/blog/new-in-symfony-3-3-asset-preloading-with-http-2-push Moreover `preload('build/style.css', { as: 'style' })` generates a good link in Sf4 but not in sf3 (relative instead of absolute). I think is confusing. I hope it can help other developers. Commits ------- d9b88d7 Add a note for preload asset
OskarStark
added a commit
that referenced
this pull request
Aug 16, 2019
* 3.4: Tweaks #12179 Add a note for preload asset
OskarStark
added a commit
that referenced
this pull request
Aug 16, 2019
* 4.3: Tweaks #12179 Add a note for preload asset
OskarStark
added a commit
that referenced
this pull request
Aug 16, 2019
* 4.4: Tweaks #12179 Add a note for preload asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a note about how to preload asset in Sf 3.4.
Indeed it was not explained. There was just a symfony blog article about it : https://symfony.com/blog/new-in-symfony-3-3-asset-preloading-with-http-2-push
Moreover
preload('build/style.css', { as: 'style' })generates a good link in Sf4 but not in sf3 (relative instead of absolute). I think is confusing.I hope it can help other developers.