Rewrite Intl introduction #12174
Merged
Rewrite Intl introduction #12174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ro0NL could you please verify this? Thank you Also this must go into |
|
i tend to agree Accessing ICU Data is the first concern of the Intl component, today. Or put different the idea of stubbing is you dont actually notice it's stubbed, so it seems less important It was much worse before though :) #11590 |
ro0NL
approved these changes
Aug 15, 2019
terjebraten-certua
force-pushed
the
intl-intro
branch
from
58ea524 to
83aa6f7
Compare
OskarStark
approved these changes
Aug 15, 2019
|
Thank you Terje. |
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Rewrite Intl introduction When I first looked at the documentation for the Intl component, I thought I was looking at the wrong place. I got the first impression that this was only about a PHP replacement layer for the C intl extension, and that was not what I was looking for. This PR is about replacing the introduction paragraph at the top to make it clear that this component may be useful to you even if you do not need the replacement layer and have the PHP intl extension installed. Commits ------- 83aa6f7 Rewrite Intl introduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first looked at the documentation for the Intl component, I thought I was looking at the wrong place. I got the first impression that this was only about a PHP replacement layer for the C intl extension, and that was not what I was looking for.
This PR is about replacing the introduction paragraph at the top to make it clear that this component may be useful to you even if you do not need the replacement layer and have the PHP intl extension installed.