Fix ctype links #12153
Merged
Fix ctype links #12153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 13, 2019
| @@ -175,5 +175,5 @@ You can use the following parameters in this message: | |||
|
|
|||
| .. include:: /reference/constraints/_payload-option.rst.inc | |||
|
|
|||
| .. _built-in PHP extension: https://php.net/book.ctype.php | |||
| .. _a list of ctype functions: https://php.net/ref.ctype.php | |||
| .. _built-in PHP extension: https://php.net/book.ctype | |||
There was a problem hiding this comment.
Maybe use https://www.php.net/book.ctype as that's what the above URL is redirected to?
There was a problem hiding this comment.
I'm using php.net instead of www.php.net because it's similar to other links in the documentation. Globally, there are more links using php.net than www.php.net.
But if you still think it's better to use the canonical URL, tell me and I will edit this.
xabbuh
approved these changes
Aug 13, 2019
OskarStark
approved these changes
Aug 13, 2019
|
@nesk thanks for this improvement ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Aug 13, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Fix ctype links Links to the ctype book and reference were dead. Commits ------- ee19b6b Fix ctype links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to the ctype book and reference were dead.