Skip to content

Remove unused links #12140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2019
Merged

Remove unused links #12140

merged 1 commit into from
Aug 14, 2019

Conversation

OskarStark
Copy link
Contributor

Refs OskarStark/doctor-rst#249

There are a lot more

@OskarStark OskarStark added this to the 3.4 milestone Aug 12, 2019
@OskarStark OskarStark force-pushed the remove-unused-links branch 4 times, most recently from 320b0b1 to 791ddd2 Compare August 14, 2019 06:44
@OskarStark OskarStark requested a review from xabbuh as a code owner August 14, 2019 06:44
@OskarStark OskarStark force-pushed the remove-unused-links branch from 791ddd2 to 20c7d10 Compare August 14, 2019 06:59
@OskarStark OskarStark changed the title [WIP] remove unused links [WIP] Remove unused links Aug 14, 2019
@OskarStark OskarStark force-pushed the remove-unused-links branch 20 times, most recently from d3ac938 to 3ff3f98 Compare August 14, 2019 08:56
@OskarStark OskarStark force-pushed the remove-unused-links branch 6 times, most recently from 0fdb422 to f0147b7 Compare August 14, 2019 09:10
@OskarStark OskarStark force-pushed the remove-unused-links branch from f0147b7 to 3aeb73e Compare August 14, 2019 09:13
@OskarStark OskarStark changed the title [WIP] Remove unused links Remove unused links Aug 14, 2019
@OskarStark
Copy link
Contributor Author

OskarStark commented Aug 14, 2019 •
edited
Loading

@javierequiluz, this one is now ready to merge 😄

javiereguiluz
javiereguiluz approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Oskar.

I also think we are sure this doesn't break anything because if we removed some still-used link, we'd see a build error 👍

@OskarStark
Copy link
Contributor Author

I also think we are sure this doesn't break anything because if we removed some still-used link, we'd see a build error 👍

Yes a lot of them occured while doing this change, so now we are safe!

Could you do me a favor and do the merge? 😃 Afterwards I will do the same against 4.3.

@javiereguiluz
Copy link
Member

Thanks Oskar.

@javiereguiluz javiereguiluz merged commit 3aeb73e into symfony:3.4 Aug 14, 2019
javiereguiluz added a commit that referenced this pull request Aug 14, 2019
@javiereguiluz
minor #12140 Remove unused links (OskarStark)
ada98d1 
This PR was merged into the 3.4 branch.

Discussion
----------

Remove unused links

Refs OskarStark/doctor-rst#249

There are a lot more

Commits
-------

3aeb73e Remove unused links
@javiereguiluz
Copy link
Member

This has been merged up to master branch.

@OskarStark OskarStark deleted the remove-unused-links branch August 14, 2019 10:23
@OskarStark OskarStark mentioned this pull request Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot