Skip to content

Adding missing semicolon #12126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

Adding missing semicolon #12126

merged 1 commit into from
Aug 9, 2019

Conversation

dannykopping
Copy link
Contributor

So I'm now a Symfony contributor right? 😏

@dannykopping
Adding missing semicolon
4946c67 
So I'm now a Symfony contributor right? 😏
maxhelias
maxhelias approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start 😄

@OskarStark OskarStark added this to the 4.3 milestone Aug 9, 2019
@OskarStark
Copy link
Contributor

Thanks for fixing this bug Danny.

@OskarStark OskarStark merged commit 4946c67 into symfony:4.3 Aug 9, 2019
OskarStark added a commit that referenced this pull request Aug 9, 2019
@OskarStark
bug #12126 Adding missing semicolon (dannykopping)
d40fd82 
This PR was merged into the 4.3 branch.

Discussion
----------

Adding missing semicolon

So I'm now a Symfony contributor right? 😏

Commits
-------

4946c67 Adding missing semicolon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dannykopping @OskarStark @maxhelias @carsonbot