Simplify the core team processes #12111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Aug 7, 2019
nicolas-grekas
approved these changes
Aug 7, 2019
Tobion
reviewed
Aug 7, 2019
| * **Robin Chalas** (`chalasr`_); | ||
| * **Maxime Steinhausser** (`ogizanagi`_); | ||
| * **Samuel Rozé** (`sroze`_); | ||
| * **Yonel Ceruto** (`yceruto`_). | ||
|
|
||
| * **Deciders Team** (``@symfony/deciders`` on GitHub): |
There was a problem hiding this comment.
Didn't you remove the deciders team?
There was a problem hiding this comment.
The PR is not merged yet :)
xabbuh
approved these changes
Aug 7, 2019
yceruto
approved these changes
Aug 7, 2019
Tobion
reviewed
Aug 7, 2019
fabpot
force-pushed
the
core-team-simplifications
branch
from
dc9f6af to
f6db8e3
Compare
Tobion
reviewed
Aug 7, 2019
fabpot
force-pushed
the
core-team-simplifications
branch
from
f6db8e3 to
5f6e9d6
Compare
Tobion
approved these changes
Aug 7, 2019
Taluu
approved these changes
Aug 7, 2019
| * **Robin Chalas** (`chalasr`_); | ||
| * **Maxime Steinhausser** (`ogizanagi`_); | ||
| * **Samuel Rozé** (`sroze`_); | ||
| * **Yonel Ceruto** (`yceruto`_). |
There was a problem hiding this comment.
As you added yourself to almost all teams, shouldn't you add yourself to the mergers @fabpot ?
chalasr
approved these changes
Aug 7, 2019
|
Thank you @fabpot. |
xabbuh
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Simplify the core team processes To better reflect the reality of how we are working nowadays. Commits ------- 5f6e9d6 simplified the core team processes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better reflect the reality of how we are working nowadays.