Replace interface in custom normalizer #12093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's the same from 4.1 to 4.4 |
maxhelias
reviewed
Aug 5, 2019
|
Thanks for this contribution Tony. Please note that if this change is approved, we'll merge it in 4.3 branch, the oldest maintained branch where this is applicable (see https://symfony.com/roadmap#maintained-symfony-branches). |
|
My bad, this PR is for 4.2 minimum .... |
|
Yes thank you @javiereguiluz. Do I have to change the target of the PR ? |
… context in supportNormalization method
maxhelias
approved these changes
Aug 5, 2019
No we take care of the switch, thank you 👍 |
|
Tony, thanks for fixing this and for rebasing the pull request to the right branch. Congrats also on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Replace interface in custom normalizer Replace NormalizerInterface by ContextAwareNormalizerInterface to use `context` parameter in supportNormalization method Commits ------- a756044 Replace NormalizerInterface by ContextAwareNormalizerInterface to use context in supportNormalization method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace NormalizerInterface by ContextAwareNormalizerInterface to use
contextparameter in supportNormalization method