Improved some deprecation message #12079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Aug 2, 2019
maxhelias
approved these changes
Aug 2, 2019
OskarStark
reviewed
Aug 2, 2019
javiereguiluz
force-pushed
the
bundle_inheritance
branch
from
d1ff547 to
049e5e9
Compare
javiereguiluz
added a commit
that referenced
this pull request
Aug 2, 2019
This PR was squashed before being merged into the 3.4 branch (closes #12079). Discussion ---------- Improved some deprecation message Some user complained on Symfony's Slack about this ... and he is right. The deprecation message in 4.x is useful: https://symfony.com/doc/4.3/bundles/inheritance.html But in 3.4 is not that useful: https://symfony.com/doc/3.4/bundles/inheritance.html Commits ------- 049e5e9 Improved some deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some user complained on Symfony's Slack about this ... and he is right.
The deprecation message in 4.x is useful: https://symfony.com/doc/4.3/bundles/inheritance.html
But in 3.4 is not that useful: https://symfony.com/doc/3.4/bundles/inheritance.html