Remove strict true === $user['showEmail'] on preSubmit #12072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Aug 1, 2019
|
@xabbuh this must go in |
OskarStark
approved these changes
Aug 1, 2019
|
Yes |
|
Thanks for fixing this bug Jean-Baptiste 👏 and congrats on your first contribution to the Symfony-Docs 🎉 |
OskarStark
added a commit
that referenced
this pull request
Aug 1, 2019
…delhommeau) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #12072). Discussion ---------- Remove strict true === $user['showEmail'] on preSubmit <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> On the pre submit example. Strict condition will be used. `true === $user['showEmail']`. In pre submit value of data are not normalized. Strict operator `true === $user['showEmail']` is wrong. If we want used strict operator we can use: `'1' === $user['showEmail']`. but in case of checkbox is not checked the key `showEmail` is not set. I prefere use this condition: `isset($user['showEmail']) && $user['showEmail']` or maybe `false === empty($user['showEmail'])` ? Commits ------- 122ccaa Remove strict true === $user['showEmail'] on preSubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the pre submit example. Strict condition will be used.
true === $user['showEmail'].In pre submit value of data are not normalized. Strict operator
true === $user['showEmail']is wrong.If we want used strict operator we can use:
'1' === $user['showEmail']. but in case of checkbox is not checked the keyshowEmailis not set.I prefere use this condition:
isset($user['showEmail']) && $user['showEmail']or maybefalse === empty($user['showEmail'])?