[Form] Minor reword in the Choice type

[javiereguiluz]

This will hopefully avoid issues like #11925.

[xabbuh]

Reading the related issue it occurs to me that the reporter was referring to options of the DateIntervalType. Maybe we need to add a sentence like there too.

[javiereguiluz]

I've added more examples in the DateIntervalType docs. Thanks!

[ovgray]

The comments at lines 86, 119, 172, 187, 214 and 331 of the changed dateinterval.rst file are incorrect.

The comment at line 86 should say "values displayed to users range from 0 to 30 (both inclusive)". The other comments also misstate what the end of the displayed range would be.

The fact that these errors were made in trying to clarify this "feature" only illustrates how unintuitive the feature is.

[javiereguiluz]

I tested in the Symfony Demo app:

->add('foo', DateIntervalType::class, [
    'mapped' => false,
])

->add('foo', DateIntervalType::class, [
    'mapped' => false,
    'months' => range(1, 12),
])

->add('foo', DateIntervalType::class, [
    'mapped' => false,
    'months' => array_combine(range(1, 12), range(1, 12)),
])

[ovgray]

Your test proves my point about the comment at line 186 (not 187 as my first comment said) of dateinterval.rst.

The values displayed to users when ‘months’ is set to range(1, 12) range from 0 to 11, not 0 to 12 as your comment says.

BTW, the same sort of error appears in line 200 as well.

[javiereguiluz]

@adrx you are right! I was looking at the wrong comments! Sorry.