Update Doc : Symfony 4.3 - Swift Mailer #12040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Example, erase HelloBundle architecture by templates architecture.
weaverryan
approved these changes
Jul 26, 2019
|
In doc Symfony v4.4, this reference of bundle exist. |
|
Gary, thank you very much for fixing this error! Congrats on your first Symfony Docs contribution too! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 26, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Update Doc : Symfony 4.3 - Swift Mailer Review Example, erase HelloBundle architecture by templates architecture. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- f8d783b Update Doc : Symfony 4.3 - Swift Mailer
|
We merged this in "4.4" and "master" branches too. There are other occurrences of "HelloBundle" in the docs ... but all of them look legitimate to me because they are used when talking about bundles. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Example, erase HelloBundle architecture by templates architecture.