Use string instead of FQCN #12002
Merged
Use string instead of FQCN #12002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have other examples with default string values? Do we quote them? |
|
Then I'd do the same here too. |
|
Ok, RTM 👍 |
xabbuh
approved these changes
Jul 23, 2019
OskarStark
added a commit
that referenced
this pull request
Jul 23, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Use string instead of FQCN If the type is string, it should either be: **type**: ``string`` **default**: ``'Symfony\Component\Form\Extension\Core\Type\TextType'`` or **type**: ``string`` **default**: ``Symfony\Component\Form\Extension\Core\Type\TextType::class`` @xabbuh can you please give me some feedback here? Thanks Commits ------- 0c26a3d Use string instead of FQCN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type is string, it should either be:
type:
stringdefault:'Symfony\Component\Form\Extension\Core\Type\TextType'or
type:
stringdefault:Symfony\Component\Form\Extension\Core\Type\TextType::class@xabbuh can you please give me some feedback here? Thanks