[Security] Better explain what happens when multiple roles are passed #11988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jul 19, 2019
…es are passed (javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Security] Better explain what happens when multiple roles are passed Fixes symfony/symfony#32594 Commits ------- f001b9b [Security] Better explain what happens when multiple roles are passed
xabbuh
reviewed
Jul 19, 2019
| @@ -294,7 +294,8 @@ is_granted | |||
|
|
|||
| Returns ``true`` if the current user has the given role. If several roles are | |||
| passed in an array, ``true`` is returned if the user has at least one of | |||
| them. | |||
| them or all of them, depending on the | |||
| :ref:`Access Decision Manager strategy <security-access-control-enforcement-options>`. | |||
There was a problem hiding this comment.
I don't think this is correct (see also symfony/symfony#32594 (comment)).
javiereguiluz
added a commit
that referenced
this pull request
Aug 13, 2019
This PR was merged into the 3.4 branch. Discussion ---------- fix voting on multiple roles behavior description reverts #11988 (see my explanation at symfony/symfony#32594 (comment)) Commits ------- 4b76554 fix voting on multiple roles behavior description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes symfony/symfony#32594