Skip to content

Adds section on parallelizing tests. #11955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Adds section on parallelizing tests. #11955

merged 1 commit into from
Jul 29, 2019

Conversation

dbrumann
Copy link
Contributor

See discussion in #11757

@javiereguiluz
Copy link
Member

Denis, thanks for contributing this content. I have a comment and a question.

Question: How many jobs are run in parallel? Is it configurable? Is it automatic based on the number of cores/threads?

Comment: I appreciate your detailed explanation ... but I'd prefer to remove all mentions to "parallel" and the example shown for it. I think it's out of the scope of the Symfony Docs and not adding that would simplify future maintenance. We could, however, mention explicitly that, when using PhpUnitBridge, you don't have to install any external tools, like "parallel", to achieve this. What do others think? @xabbuh?

Thanks!

@dbrumann
Copy link
Contributor Author

dbrumann commented Jul 16, 2019

That makes sense, I mainly put it there as a reference as this is how symfony/symfony parallelizes the suites and people who look at the .travis.yml might be interested to know what's happening in there. I agree though that it complicates the section a bit and is not really tied to the PhpUnitBridge.

As far as I can tell, there is no way to configure how parallelization is done. The script collects all subfolders containing a phpunit.xml.dist and then loops over the results spawning a process for each one and then waits for all of them to finish; see: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php#L207-L222

@xabbuh
Copy link
Member

xabbuh commented Jul 19, 2019

I agree with Javier. I would also only keep the PHPUnit bridge related part.

@javiereguiluz
Copy link
Member

Thanks for contributing these new contents and for rewording them during the review process.

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 29, 2019
This PR was squashed before being merged into the 3.4 branch (closes symfony#11955).

Discussion
----------

Adds section on parallelizing tests.

See discussion in symfony#11757

Commits
-------

ddd5f05 Adds section on parallelizing tests.
@javiereguiluz javiereguiluz merged commit ddd5f05 into symfony:3.4 Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants