Bug fix: Update collection.rst #11944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Sep 26, 2019
| @@ -182,7 +182,7 @@ And update the template as follows: | |||
| <ul id="email-fields-list" | |||
| data-prototype="{{ form_widget(form.emails.vars.prototype)|e }}" | |||
| data-widget-tags="{{ '<li></li>'|e }}" | |||
| data-widget-counter="{{ form.children|length }}"> | |||
| data-widget-counter="{{ form.emails|length }}"> | |||
There was a problem hiding this comment.
It is clear to me that the length of $form->children is not the same as the length of $form->children['emails'], so the fix is correct.
|
Thank you @MarvinBlstrli and thanks Yonel for the review! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 26, 2019
This PR was merged into the master branch. Discussion ---------- Bug fix: Update collection.rst form.children returns the children of the parent form, but at this point we need the length of children of the childform. Example: If form.children|length returns 3 and you add some childs the counter count up the data-widget-counter attribute. But after submit (with validation errors) the attribute has "3" again. Steps to reproduce: 1. Add form with child form as collection type like the documentation mentioned 2. Add validation to those fields 3. Check value of data-widget-counter 5. Click the "add" button and and some child fields (check value of data-widget-counter again) 5. Leave empty and submit the form 6. Now you see those fields with validation errors - check value of data-widget-counter - it has the same value from beginning (without fields added) and not the length of fields from child form Commits ------- 2814081 fix data-widget-counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
form.children returns the children of the parent form, but at this point we need the length of children of the childform.
Example:
If form.children|length returns 3 and you add some childs the counter count up the data-widget-counter attribute. But after submit (with validation errors) the attribute has "3" again.
Steps to reproduce: