Skip to content

Remove extra time for security fixes on standard versions #11872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jul 3, 2019

Fixing security issues on standard versions is complicated as the branches diverged a lot. In any case, if someone wants to stick to standard versions (which I would highly recommend), there is already time to do so. So, the extra time for security issues does serve any purpose IMHO.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we'll have to change the SVG on https://symfony.com/roadmap)

@xabbuh xabbuh added this to the 3.4 milestone Jul 3, 2019
@weaverryan
Copy link
Member

Each time a minor ("standard") version is released, you will have 2 months to upgrade (the same as before if you cared about bug fixes). The overall idea is that, thanks to the BC policy, upgrading minor versions is safe, simple and quick.

@javiereguiluz
Copy link
Member

I propose to fix this in 4.4 branch (or master) to avoid confusion with earlier Symfony versions.

@fabpot
Copy link
Member Author

fabpot commented Jul 3, 2019

Makes sense to merge it in 4.4 instead.

@javiereguiluz javiereguiluz modified the milestones: 3.4, 4.4 Jul 4, 2019
@javiereguiluz javiereguiluz changed the base branch from 3.4 to 4.4 July 4, 2019 07:37
@javiereguiluz javiereguiluz force-pushed the security-issues-fix-for-standard-releases branch from 090c977 to 52fa1ce Compare July 4, 2019 07:37
@javiereguiluz
Copy link
Member

Thanks! Merged in 4.4.

@javiereguiluz javiereguiluz merged commit 52fa1ce into symfony:4.4 Jul 4, 2019
javiereguiluz added a commit that referenced this pull request Jul 4, 2019
…s (fabpot)

This PR was submitted for the 3.4 branch but it was merged into the 4.4 branch instead (closes #11872).

Discussion
----------

Remove extra time for security fixes on standard versions

Fixing security issues on standard versions is complicated as the branches diverged a lot. In any case, if someone wants to stick to standard versions (which I would highly recommend), there is already time to do so. So, the extra time for security issues does serve any purpose IMHO.

Commits
-------

52fa1ce Remove extra time for security fixes on standard versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants