More updates related to Symfony configuration #11803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
new_config_tweak
branch
from
f3334df to
b0a3b25
Compare
weaverryan
requested changes
Jun 29, 2019
javiereguiluz
force-pushed
the
new_config_tweak
branch
from
b0a3b25 to
7946db7
Compare
|
I've made most of the suggested changes, so I think this is ready for the final review. Thanks. |
javiereguiluz
force-pushed
the
new_config_tweak
branch
from
80b96ae to
c7a62b8
Compare
javiereguiluz
added a commit
that referenced
this pull request
Jul 31, 2019
…iluz) This PR was squashed before being merged into the 4.3 branch (closes #11803). Discussion ---------- More updates related to Symfony configuration This makes several changes related to config. 1) Now that the TOC is displayed so prominently, it's easy to spot things to improve in the article hierarchy. So, I've made the following changes (left: before, right: after):  2) the multiple ".env" files section has been reworded and now it follows the same structure as the comments of the associated recipe, which I think are better. 3) The main Confgi article now explains the different kinds of params you can define ... so we've deleted the service_container/parameters.rst article which is no longer needed. 4) The main Config article adds a new section to explain how to get config values in services and controllers. With these changes I considered finished the main Config article. Thanks. Commits ------- c7a62b8 More updates related to Symfony configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes several changes related to config.
the multiple ".env" files section has been reworded and now it follows the same structure as the comments of the associated recipe, which I think are better.
The main Confgi article now explains the different kinds of params you can define ... so we've deleted the service_container/parameters.rst article which is no longer needed.
The main Config article adds a new section to explain how to get config values in services and controllers.
With these changes I considered finished the main Config article. Thanks.