Use valid number of backslashes, depending on 1 or 2 ticks #11771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@javiereguiluz I created a rule for the doctor 👍
OskarStark
commented
Jun 18, 2019
| @@ -13,7 +13,7 @@ simple principle: the logic is about creating the Response associated with a | |||
| Request. | |||
|
|
|||
| Let's create our very own namespace for our framework: ``Simplex``. Move the | |||
| request handling logic into its own ``Simplex\\Framework`` class:: | |||
| request handling logic into its own ``Simplex\Framework`` class:: | |||
There was a problem hiding this comment.
When using 2 backticks, 1 backslash is enough, otherwise it looks like this:
Which isn't a valid namespace.
OskarStark
commented
Jun 18, 2019
| @@ -94,7 +94,7 @@ public methods and properties. | |||
| .. caution:: | |||
|
|
|||
| Classes, properties and methods that bear the tag ``@internal`` as well as | |||
| the classes located in the various ``*\\Tests\\`` namespaces are an | |||
| the classes located in the various ``*\Tests\`` namespaces are an | |||
OskarStark
commented
Jun 18, 2019
| @@ -199,7 +199,7 @@ assetic.formula_loader | |||
| **Purpose**: Add a formula loader to the current asset manager | |||
|
|
|||
| A Formula loader is a class implementing | |||
| ``Assetic\\Factory\Loader\\FormulaLoaderInterface`` interface. This class | |||
| ``Assetic\Factory\Loader\FormulaLoaderInterface`` interface. This class | |||
There was a problem hiding this comment.
This was definitely wrong before 😄 and now spotted by the doctor 💃
javiereguiluz
approved these changes
Jun 18, 2019
Don't worry, we will spot them automagically in the future 😃 |
OskarStark
added a commit
that referenced
this pull request
Jun 18, 2019
…ks (OskarStark) This PR was merged into the 3.4 branch. Discussion ---------- Use valid number of backslashes, depending on 1 or 2 ticks @javiereguiluz I created a rule for the doctor 👍 After merging, I will check the other branches, too 👍 Commits ------- abe4c85 Use valid number of backslashes, depending on 1 or 2 ticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@javiereguiluz I created a rule for the doctor 👍
After merging, I will check the other branches, too 👍