Skip to content

Clarify some words about simple-phpunit #11757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Clarify some words about simple-phpunit #11757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions components/phpunit_bridge.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ The PHPUnit Bridge
==================

The PHPUnit Bridge provides utilities to report legacy tests and usage of
deprecated code and a helper for time-sensitive tests.
deprecated code and helpers for mocking native functions related to time,
DNS and class existence.

It comes with the following features:

Expand All @@ -19,10 +20,13 @@ It comes with the following features:

* Displays the stack trace of a deprecation on-demand;

* Provides a ``ClockMock`` and ``DnsMock`` helper classes for time or network-sensitive tests.
* Provides a ``ClockMock``, ``DnsMock`` and ``ClassExistsMock`` classes for tests
sensitive to time, network or class existence.

* Provides a modified version of PHPUnit that does not embed ``symfony/yaml`` nor
``prophecy`` to prevent any conflicts with these dependencies.
* Provides a modified version of PHPUnit that allows 1. separating the
dependencies of your app from those of phpunit to prevent any unwanted
constraints to apply; 2. running tests in parallel when a test suite is split
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this, parallelizing tests, could be highlighted more? Do you think it's worth adding a small section to this page giving a brief introduction why it's useful and how it works? If so, I could make a PR when I have some time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice indeed, I was totally unaware of that one...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrumann this has been merged, but it'd be nice to add a short section about parallelizing tests. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do an additional PR maybe this weekend.

in several phpunit.xml files; 3. recording and replaying skipped tests.

Installation
------------
Expand Down Expand Up @@ -570,8 +574,8 @@ Modified PHPUnit script
This bridge provides a modified version of PHPUnit that you can call by using
its ``bin/simple-phpunit`` command. It has the following features:

* Does not embed ``symfony/yaml`` nor ``prophecy`` to prevent any conflicts with
these dependencies;
* Works with a standalone vendor directory that doesn't conflict with yours;
* Does not embed ``prophecy`` to prevent any conflicts with its dependencies;
* Uses PHPUnit 4.8 when run with PHP <=5.5, PHPUnit 5.7 when run with PHP >=5.6
and PHPUnit 6.5 when run with PHP >=7.2;
* Collects and replays skipped tests when the ``SYMFONY_PHPUNIT_SKIPPED_TESTS``
Expand Down