[Messenger] Fixing & improving autowireable names section #11745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and removing unnecessary section
maxhelias
approved these changes
Jun 14, 2019
|
Thanks Ryan. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 14, 2019
…n (weaverryan) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fixing & improving autowireable names section tl;dr In 4.3, you get automatic autowireable "names" for each message bus, so the second section is not needed at all. And by tweaking the bus names, we get better autowireable names than before. Commits ------- 49c0a0a renaming services to get better autowireable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
In 4.3, you get automatic autowireable "names" for each message bus, so the second section is not needed at all. And by tweaking the bus names, we get better autowireable names than before.