Update impersonating_user.rst #11723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acrnogor
commented
Jun 11, 2019
acrnogor
commented
- request->getSession method call was missing brackets - fixed
javiereguiluz
added
bug
Security
Status: Reviewed
and removed
Status: Needs Review
labels
|
@acrnogor good catch! Thanks for fixing this bug! We merged it in 4.2 branch (the oldest maintained branch that contains the error) and we'll merge in the other branches automatically. GitHub shows this as "closed" instead of "merged" because of this branch change, but it's "merged". Also, congrats on your first Symfony Docs contribution! |
- request->getSession method call was missing brackets - fixed
javiereguiluz
added a commit
that referenced
this pull request
Jun 11, 2019
This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #11723). Discussion ---------- Update impersonating_user.rst - request->getSession method call was missing brackets - fixed <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 685757b Update impersonating_user.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.