Recommend FOSCKE instead of Ivory WYSIWYG editor #11694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Jun 7, 2019
javiereguiluz
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
@wouterj which branch should we merge this on? 3.4 or 4.2? Thanks.
|
Seems like they support 3.4 in all their versions currently: https://packagist.org/packages/friendsofsymfony/ckeditor-bundle so let's do 3.4 |
|
I can handle the rebase. Or you prefer to switch the branch by yourself? |
|
Thanks Jérémy, but we can switch the branch while merging. |
OskarStark
approved these changes
Jun 8, 2019
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bundle IvoryCKEditorBundle was abandoned, it documentation automatically redirect to "https://symfony.com/doc/current/bundles/FOSCKEditorBundle/index.html" and this documentation contains an article explaining how to migrate from Ivory to Fos.
This PR fix Symfony Form documentation to point to FosCke instead of IvoryCke