[WebLink] All mentions to preload must have an "as" attribute #11615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the examples mentionning a `preload` must contain also a `'as' => 'xxx'` attribute. Otherwise, it generates a warning on the browser console: ``` <link rel=preload> must have a valid `as` value` ```
tristanbes
changed the title
|
In the official standard we can confirm that it's mandatory: https://w3c.github.io/preload/#as-attribute @tristanbes thanks for fixing this error. We're going to merge in 3.4 branch and then in the other branches too. |
|
@javiereguiluz do I need to change base branch to 3.4 ? |
|
No, don't worry. We can change the base while merging. The only problem is that in those cases, GitHub displays the PR as "closed" instead of "merged", but it's merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the examples mentionning a
preloadmust contain also a'as' => 'xxx'attribute. Otherwise, it generates a warning on the browser console: