-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Updated doctrine links for 2.2, fixes #1149 #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix typo in web_profile.verbose description
@@ -170,4 +170,4 @@ The last command generated all getters and setters for your two ``BlogPost`` and | |||
``BlogComment`` entity class properties. The generated entities are now ready to be | |||
used. Have fun! | |||
|
|||
.. _`Doctrine tools documentation`: http://docs.doctrine-project.org/projects/doctrine-orm/en/2.1/reference/tools.html#reverse-engineering | |||
.. _`Doctrine tools documentation`: http://www.doctrine-project.org/docs/orm/2.2/en/reference/tools.html#reverse-engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong. The doc is now on docs.doctrine-project.org
so you should link to it properly instead of relying on the redirection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof corrected, should i update the other links to use docs.doctrine-project.org
also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, all doc links
Updated links to not rely on redirect as per @stof suggestion |
@stof @weaverryan any more recommendations or changes for this to be merged? |
Updated doctrine links for 2.2, fixes #1149
Hi Matthew! Nope, you're in good shape :). One thing to keep in mind is that when "current" changes to really be 2.3 and 2.2 gets its own number, we'll need to update. There's no real way around that (I'm pro the use of Thanks! |
readthedocs supports "latest" als placeholder for the master branch, so that is something to use. |
No description provided.