Skip to content

fix varnish comment #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2019
Merged

Conversation

OskarStark
Copy link
Contributor

according to this link:
https://varnish-cache.org/docs/trunk/reference/vcl.html#comments

a multiline comment should not start on the "/*"-line

@OskarStark OskarStark added this to the 3.4 milestone May 3, 2019
according to this link:
https://varnish-cache.org/docs/trunk/reference/vcl.html#comments

a multiline comment should not start on the "/*"-line
@OskarStark OskarStark force-pushed the varnish-comment-indention branch from 4f6cb06 to f66d3eb Compare May 3, 2019 06:33
@javiereguiluz javiereguiluz merged commit f66d3eb into symfony:3.4 May 3, 2019
javiereguiluz added a commit that referenced this pull request May 3, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

fix varnish comment

according to this link:
https://varnish-cache.org/docs/trunk/reference/vcl.html#comments

a multiline comment should not start on the "/*"-line

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

f66d3eb fix varnish comment
@javiereguiluz
Copy link
Member

Thanks Oskar. To avoid further problems, while merging I changed this to use single line comments.

@OskarStark OskarStark deleted the varnish-comment-indention branch May 3, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants