HTTP Cache - update for index.php snippet #11496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New index.php does not contains `$env` variable. Some developers might copy-paste blindly (like I did) and waste some time figuring-out why CacheKernel is not in use even when app is in `prod`.
broiniac
changed the title
javiereguiluz
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
We always follow the official Symfony recipes strictly. The recipe for index.php has changed several times ... so the current docs show an outdated version of it.
The changes made in this PR makes it again similar to the index.php file created by the official recipe. See https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/4.2/public/index.php
Thanks @broiniac!
|
Thanks for fixing this ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 30, 2019
This PR was merged into the 4.2 branch. Discussion ---------- HTTP Cache - update for index.php snippet New index.php does not contains `$env` variable. Some developers might copy-paste blindly (like I did) and waste some time figuring-out why CacheKernel is not in use even when app is in `prod`. Commits ------- 660fc83 Update for index.php snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New index.php does not contains
$envvariable. Some developers might copy-paste blindly (like I did) and waste some time figuring-out why CacheKernel is not in use even when app is inprod.