Document the UserValueResolver #11468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz Thx for the merge. I've rebased my branch, should be good now. |
javiereguiluz
added
Status: Reviewed
HttpKernel
and removed
Status: Needs Review
labels
javiereguiluz
added a commit
that referenced
this pull request
Apr 24, 2019
This PR was merged into the 4.2 branch. Discussion ---------- Document the UserValueResolver Fixes #10595, followup to #11467. **NOTE**: This PR has all the changes that #11467 has plus some symfony 4.2 specific additions, so #11467 should probably be merged first. Commits ------- b72a65e Document the UserValueResolver
|
Very nice continuation of your previous work about this! Thanks for your contributions!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10595, followup to #11467.
NOTE: This PR has all the changes that #11467 has plus some symfony 4.2 specific additions, so #11467 should probably be merged first.